Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Implied but undocumented relationships with size_frac #391

Closed
Tracked by #587
turbomam opened this issue Jul 27, 2021 · 3 comments
Closed
Tracked by #587

Implied but undocumented relationships with size_frac #391

turbomam opened this issue Jul 27, 2021 · 3 comments

Comments

@turbomam
Copy link
Member

turbomam commented Jul 27, 2021

This is one component of #375

First, MIxS says size_frac not size_fract

Next, the NMDC Sample Metadata Template seems to imply that

  • filter_type
  • sieving

Are sub-properties of the size_frac property. MIxS does not make those assertions.

The NMDC Sample Metadata Template also uses an undefined filter_size

It doesn't seem like the size_frac slot is ever used directly

@mslarae13
Copy link

Note added to corret size_fract to frac

Definition for MIxS is "filtering pore size used in sample preparation" so it's more preparation metadata. I'm open to suggestions on what this should be. But, MIxS is more analyte preparation metadata & defines sample more as the analysis subsample than the biological sample itself. In my attempt to not diverge from MIxS, this is the field I felt best fit the information I was gathering.

@turbomam
Copy link
Member Author

turbomam commented Aug 2, 2021

OK, I appreciate the effort to use MIxS terms. I may not really get the distinction you're making between MIxS's sample prep orientation and the orientation you're trying to emphasize.

I'm going to continue working through your recent posts and responses. I'll probably want a one-on-one live meeting soon.

@mslarae13
Copy link

mslarae13 commented May 8, 2023

frac vs fract taken care of

sub property is irrelevant now.

IF size_frac is brought up again we can refer back.

@pkalita-lbl pkalita-lbl closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in SubPort Squad Issues May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ SubPort 1 - Done
Development

No branches or pull requests

4 participants