Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right default directory for charts #50

Open
vromero opened this issue Sep 11, 2018 · 0 comments
Open

Right default directory for charts #50

vromero opened this issue Sep 11, 2018 · 0 comments

Comments

@vromero
Copy link

vromero commented Sep 11, 2018

In PackageMojo.java and in the documentation we can see that chartContentsUri by default points to file:${project.basedir}/src/helm/charts/${project.artifactId}/.

However, the standard directory layout of maven would suggest that the default directory should be file:${project.basedir}/src/main/helm/charts/${project.artifactId}/. Specifically the paragraphs:

Within artifact producing source directories (ie. main and test), there is one directory for the language java (under which the normal package hierarchy exists), and one for resources (the structure which is copied to the target classpath given the default resource definition).

If there are other contributing sources to the artifact build, they would be under other subdirectories: for example src/main/antlr would contain Antlr grammar definition files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant