Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests dont use latest source when PR includes changes to PycroManagerJava #653

Closed
henrypinkard opened this issue Aug 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@henrypinkard
Copy link
Member

When making a PR with changes to PycroManagerJava, the tests do not use the latest source code (in the PR). This means that passing the tests requires changes there, they will not pass. In theory this should be possible by using maven to build the jar based on the latest source and using that to the run the tests, and I think thats what the testing framework is trying to do, but something must be going wrong...

@ieivanov
Copy link
Collaborator

ieivanov commented Aug 3, 2023

@henrypinkard I think your experience is consistent with the current intended behavior. When the tests run in GitHub Action, we only use the .jar files which ship with Micro-manager. You're right that if we make changes to PycroManagerJava we should use that new code. Currently the build_and_test.yml workflow builds the PycroManagerJava.jar file, but it seems like we don't use it during testing. That can be fixed.

@henrypinkard
Copy link
Member Author

Added as part of #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants