Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Basler entry on device page #113

Open
henrypinkard opened this issue Feb 23, 2023 · 3 comments
Open

Duplicate Basler entry on device page #113

henrypinkard opened this issue Feb 23, 2023 · 3 comments

Comments

@henrypinkard
Copy link
Member

henrypinkard commented Feb 23, 2023

There are currently both BaslerCameras and BaslerAce entries on the devices page. BaslerAce is the one I wrote. BaslerCameras was added later by someone who worked at Basler named Felix Asche (but before the website was on github).

So far as I can tell, there is no device adapter corresponding to BaslerCameras. They have this application note on their website, which describes how to install MM and setup the HCW, but no instructions about installing a device adapter. Instead, they just use one that is already present, which (I think) is the one I wrote.

In light of this confusion, I propose to delete the BaslerCameras entry

@marktsuchida marktsuchida transferred this issue from micro-manager/mmCoreAndDevices Mar 6, 2023
@marktsuchida
Copy link
Member

I'm also confused....

The only device adapter I see currently is BaslerPylon, so we should have a single page with that name (and redirect from both BaslerCameras and BaslerAce).

The BaslerPylon adapter is the code currently in the DeviceAdapters/Basler directory. It is also what is used in that application note. This directory used to be named BaslerAce, but it looks like BaslerAce and BaslerPylon5 (by Ravi, but maybe based on your code?) coexisted in that directory for a time until BaslerAce was removed. BaslerPylon5 was later renamed to BaslerPylon6 and then to BaslerPylon.

@henrypinkard
Copy link
Member Author

I'm pretty sure Ravi copied and pasted my code and made an updated version of it, and then there were two versions until the original that I made disappeared. So there was never really a reason to have two different ones. In any case, I think it makes sense to delete the two current pages and make one BaslerPylon that reflects the true situation or merge them into one

@marktsuchida
Copy link
Member

Yeah, that sounds good to me. You can add redirects by using the following page header (in case you're not already aware):

---
title: BaslerPylon
redirect_from:
  - /BaslerAce
  - /BaslerCameras
  - /wiki/BaslerAce
  - /wiki/BaslerCameras
layout: page
---

(The ones with 'wiki' redirect from the URLs prior to our move to GitHub Pages.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants