added guard to prevent dealloc and realloc on null ptr #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-lange
reviewed
Jun 30, 2020
| } | ||
|
|
||
| void * __freertos_reallocate(void * pointer, size_t size, void * state){ | ||
| (void) state; | ||
| // printf("-- Realloc %d -> %d (prev: %d B)\n",getBlockSize(pointer),size, xPortGetFreeHeapSize()); | ||
| absoluteUsedMemory += size; | ||
| usedMemory += size; | ||
| usedMemory -= getBlockSize(pointer); | ||
| return pvPortRealloc(pointer,size); | ||
| if (NULL != pointer){ |
There was a problem hiding this comment.
For readability, I propose to swap the two cases, in order to avoid an else-branch for a unequal comparison.
|
Thank you very much for the contribution, @alsaibie. |
ralph-lange
approved these changes
Jun 30, 2020
fofolevrai
pushed a commit
to fofolevrai/freertos_apps
that referenced
this pull request
Jun 14, 2021
Source for before building to fix agent build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to memory management. Based on this issue.