Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify label sync behavior #44

Closed
br3ndonland opened this issue Jul 20, 2020 · 2 comments · Fixed by #46
Closed

Clarify label sync behavior #44

br3ndonland opened this issue Jul 20, 2020 · 2 comments · Fixed by #46

Comments

@br3ndonland
Copy link
Contributor

Thanks for this action, it's really helpful.

It would be helpful to clarify the behavior of the action. Based on using the action and reading github.go, it appears to be doing the following:

  • If a label color changes, the same label is updated with the new color
  • If a label name changes, the previous label is deleted. All issues and PRs that were previously labeled with this label are now unlabeled.

Is this correct?

I'm happy to submit a PR to update the README with this info.

@displague
Copy link

I would also like to see this behavior documented.

It's not clear to me if the repository using a source repo as a reference will remove any custom labels that are not included in that repository.

It's not clear to me if the reference file is only sourced from the specified repository or if a local copy of that file could be used to append labels to the list.

@micnncim
Copy link
Owner

micnncim commented Oct 8, 2020

Sorry for the late reply 🙇‍♂️

  • If a label color changes, the same label is updated with the new color
  • If a label name changes, the previous label is deleted. All issues and PRs that were previously labeled with this label are now unlabeled.

Your assumption is correct! So please be careful if you try to change label names.

micnncim pushed a commit that referenced this issue Oct 9, 2020
#44

- If a label color changes, the same label is updated with the new color
- If a label name changes, the previous label is deleted. All issues and
  PRs that were previously labeled with this label are now unlabeled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants