Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop worker all #63

Open
lightglitch opened this issue Nov 14, 2013 · 4 comments
Open

stop worker all #63

lightglitch opened this issue Nov 14, 2013 · 4 comments

Comments

@lightglitch
Copy link
Contributor

When you stop all workers executing

bcc:resque:worker-stop --all

you should filter and only kill the ones on the machine where the script is executed.
Because now you can send kill to others services.

I will try to do a pull request ...

@lightglitch
Copy link
Contributor Author

It's possible to create a branch based on 1.1.7 so that I can create the pull request for the 1.1.8 version?

@mrbase
Copy link
Contributor

mrbase commented Nov 25, 2013

as i see it you should make a pull request against the master branch - we should then decide if not the master branch is stable enough to tag the next version aka. 1.1.8

@lightglitch
Copy link
Contributor Author

I just though that the master was going to be 1.2 or something because of the upgrade of the dependencies:

8a097a7
26532ed

I don't think that a maintenance release should have the external libraries upgraded like that because of breaking changes, but that's my opinion I leave the decision to you.

If that is your decision I need to be careful when upgrading from 1.1.7 to 1.1.8 to not break my code.

I will make the pull to master, then.

@mrbase
Copy link
Contributor

mrbase commented Nov 25, 2013

ahm, that seams fair .. guess we have to address versioning in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants