From 53c99831e45383e72be276c673ffa2de55a50f7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yoann=20Rodi=C3=A8re?= Date: Sun, 10 Sep 2023 17:36:47 +0200 Subject: [PATCH] Make it more obvious in CONTRIBUTING.md that native-tests.json needs to be updated --- CONTRIBUTING.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index faeaf9d0f01a56..78001890270911 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -213,6 +213,11 @@ Be sure to test your pull request in: 1. Java mode 2. Native mode +Also, make sure that any native tests you add will actually get executed on CI. +In the interest of speeding up CI, the native build job `native-tests` have been split into multiple categories which +are run in parallel. This means that each new integration test module needs to be configured explicitly +in [`native-tests.json`](.github/native-tests.json) to have its integration tests run in native mode. + ## Setup If you have not done so on this machine, you need to: @@ -752,7 +757,7 @@ This project is an open source project, please act responsibly, be nice, polite * The native integration test for my extension didn't run in the CI In the interest of speeding up CI, the native build job `native-tests` have been split into multiple categories which - are run in parallel. This means that each new extension needs to be configured explicitly + are run in parallel. This means that each new integration test module needs to be configured explicitly in [`native-tests.json`](.github/native-tests.json) to have its integration tests run in native mode. * Build aborts complaining about missing (or superfluous) `minimal *-deployment dependencies`