Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaAsyncExecutor : Be able to support different Kafka providers #5

Open
twobeeb opened this issue Mar 10, 2021 · 0 comments
Open
Labels
feature This issue adds a new feature

Comments

@twobeeb
Copy link
Contributor

twobeeb commented Mar 10, 2021

Currently, the only Kafka method in KafkaAsyncExecutor for creating Topics is by using AdminClient
While it's probably going to cover 100% of Kafka provider, the same cannot be said regarding ACL or user creation:

  • ACL could be managed multiple ways
    • using AdminClient (probably most use cases)
    • using Confluent RBAC (because why not)
  • SCRAM Users can be created :
    • With ZK as of now
    • With Admin Client for on prem instances starting Kafka 2.7.0
    • With API calls on Confluent API for Confluent Cloud
    • With <other_method> call on <other_provider>

All of this points to adding a new layer of abstraction in order to be able to manage different resource creation/updation methods depending on provider/on-prem

Discussion is required in order to find the best way to rewrite this.

@twobeeb twobeeb added the refactor The change is an optimisation of the code base without any functional changes label Mar 10, 2021
@twobeeb twobeeb added the API label Mar 19, 2021
@twobeeb twobeeb added feature This issue adds a new feature and removed refactor The change is an optimisation of the code base without any functional changes labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue adds a new feature
Projects
None yet
Development

No branches or pull requests

2 participants