Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some misaligned text in localization (for example russian) #395

Open
alabuzhev opened this issue Feb 22, 2024 · 0 comments
Open

Some misaligned text in localization (for example russian) #395

alabuzhev opened this issue Feb 22, 2024 · 0 comments

Comments

@alabuzhev
Copy link
Contributor

FarGroup#41 by @CfYz-R

image

image

Modifying language files doesn't work...

About window has the same issue even in default English language...


@yulian5:
The problem here is that the width for all Dialogs I checked is hard-coded.

I made a fix for 2 mentioned dialogs
231218.NetBox.patch
and then I found that all dialogs should be fixed so I stopped here.

I think the best approach will be to pass the width from TFarText to parent like TFarDialog and calculate minimum width already inside parent dialog. So I think it's will be fine to apply provided patch for mentioned 2 dialogs and then I proceed with more improvements for all other dialogs.

I tested fixes with all 3 languages for NetBox, looks fine. For "About" dialog there is an extra space on the right side, not clear where it come from. I checked a few dialogs from Far Manager, some of then also have that extra space on the right.

Alex,

I didn't provide any changelog changes or version changes. Please, let me know, If I need to.

I see that NetBox actually needs a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant