New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fs calls without callback #13

Merged

michaelleeallen merged 1 commit into michaelleeallen:master from BridgeAR:master

Apr 27, 2018

Contributor

BridgeAR commented Mar 6, 2018

This is long deprecated and it will throw from Node.js 10.x on. See nodejs/node#18668.

Right now errors are silently swallowed.


          Fix fs calls without callback

644a971

BridgeAR force-pushed the master branch from 3e7d297 to 644a971 Compare

March 6, 2018 17:18

Contributor Author

BridgeAR commented Mar 18, 2018

Ping @michaelleeallen

Contributor Author

BridgeAR commented Apr 3, 2018

Ping @michaelleeallen @mallenbmw

michaelleeallen merged commit 4eb394c into michaelleeallen:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet