Request context with promises?

[SlowShip]

Hey, great module. It's been really helpful.

I can't seem to get it to work with promises though, are they supported?

I've got a minimal replication of it failing here incase I'm doing anything wrong.

here is the main point of failure - the contextService.get works fine normally but returns undefined inside a promise:

app.get('/', (req, res) => {
  contextService.set('myNamespace:someVal', 'myValue');
  console.log(contextService.get('myNamespace:someVal')); // logs myValue as expected

  return Promise
  .resolve(null)
  .then(() => {
    console.log(contextService.get('myNamespace:someVal')); // logs undefined
    res.send('done...');
  });
});

Thanks for your time

[michaelkrone]

Hi @SlowShip,

glad this code is helpful.
Unfortunately this node.js bug prevents domains working with native Promises: nodejs/node-v0.x-archive#8648
As a workaround you might use bluebird as const Promise = require('bluebird'), or even global.Promise = ...

Since Domains are deprecated, I am working on an API compatible replacement.
Stay tuned. I will leave this bug open for tracking further process on this task.

[SlowShip]

Cool. Thanks for the work arounds, will keep an eye on this.

[SlowShip]

For anyone else suffering the same issue, I ended up installing bluebird and using global.Promise = require('bluebird'); right at the top of my applications startup script as @michaelkrone suggested and it works beautifully. Just be careful as you're changing every promise use to another implementation which should be fine, but might have some side effects.

Thanks again.

[pieterwillaert]

any updates on this issue? this bug should be documented in the readme.

[cmpaul]

This appears to be resolved (I'm using native promises on node.js v8.4.0 and express v4.16.3).