Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issue: example.tag gets modified during build, add to .gitignore. #644

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Minor issue: example.tag gets modified during build, add to .gitignore. #644

merged 1 commit into from
Mar 28, 2021

Conversation

ropg
Copy link
Contributor

@ropg ropg commented Feb 18, 2021

Line 2 in examples/doxygen/example.tag goes from

<tagfile>

to

<tagfile doxygen_version="1.8.20" doxygen_gitid="f246dd2f1c58eea39ea3f50c108019e4d4137bd5">

every time I build on a Mac. I propose to add this file to .gitignore so one doesn't have to manually exclude it each time.

@ropg ropg changed the title Minor issue: example.tag get modified during build, so .gitignore. Minor issue: example.tag gets modified during build, add to .gitignore. Feb 19, 2021
@vermeeren vermeeren self-requested a review March 28, 2021 23:55
@vermeeren vermeeren self-assigned this Mar 28, 2021
@vermeeren vermeeren added the packaging Requirements, setup.py, etc label Mar 28, 2021
vermeeren
vermeeren approved these changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ropg I note this behaviour too on Linux, it seems rather recent as Doxygen 1.8.13 from Debian buster did not do this, but Doxygen 1.9.1 from Debian bullseye does. Thanks for the fix!

michaeljones pushed a commit that referenced this pull request Mar 28, 2021
@vermeeren
changelog: update for #644
53948b4
@michaeljones michaeljones merged commit d67315b into breathe-doc:master Mar 28, 2021
@vermeeren vermeeren removed the packaging Requirements, setup.py, etc label Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermeeren vermeeren vermeeren approved these changes

@utzig utzig utzig approved these changes

Assignees

@vermeeren vermeeren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ropg @utzig @vermeeren @michaeljones