Fix anchors on pages generated by Doxygen>=1.8.17 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doxygen has changed the structure of generated XML slightly since version 1.8.13 for "page" generation. Before it would put the anchor inside a `<varlistentry><term>` block, and on version 1.8.17 and newer, it inserts the anchor inside the matching `<listitem><para>`. The `<variablelist>` block structure is still the same, so this commit only adds support for parsing anchors inside a `<para>` so it works on both XML generated by old and new versions of Doxygen. Signed-off-by: Fabio Utzig <[email protected]>
|
@vermeeren This will be required for GH workflows in the near future since Github started upgrading them to Ubuntu focal which bundles Doxygen 1.8.17 (previous Ubuntu releases bundled 1.8.13). I usually use the same version as the CI so that's why I'd not seen this issue before! |
vermeeren
added
bug
vermeeren
approved these changes
Dec 1, 2020
|
@utzig Thanks for the fix, I also didn't notice either locally as Debian buster also has Doxygen 1.8.13, so it worked properly so far. Will bump version and release after merging this. |
michaeljones
pushed a commit
that referenced
this pull request
Dec 1, 2020
|
Done, release made and of course also pushed to PyPI as usual. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doxygen has changed the structure of generated XML slightly since version 1.8.13 for "page" generation. Before it would put the anchor inside a
<varlistentry><term>block, and on version 1.8.17 and newer, it inserts the anchor inside the matching<listitem><para>.The
<variablelist>block structure is still the same, so this commit only adds support for parsing anchors inside a<para>so it works on both XML generated by old and new versions of Doxygen.