Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies some of the code by using more of the (semi-)recent features in core Sphinx. As I only tested it on the Breathe documentation I suggest that some people with more experience with using Breathe double checks the effects of the changes.
The following are the changes I either expect or have observed:
This means enumerators are now injected in the parent scope as in C++. I'm not sure what happens with enum structs/classes though.
It also means that permalinks from before enum/unions were supported in Sphinx probably will break.
visit_enumvalue
method). This was from before where they use another directive. I suggest removing theupdate_signature
part there, so make enumerators consistent with other directives.