Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner doen't show when you set the active property in code. #91

Open
Warwizza opened this issue Oct 8, 2021 · 5 comments
Open

Spinner doen't show when you set the active property in code. #91

Warwizza opened this issue Oct 8, 2021 · 5 comments

Comments

@Warwizza
Copy link

Warwizza commented Oct 8, 2021

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Windows 10.

Versions

Angular 12.2.9
mat-progress-buttons 9.3.1

Repro steps

Open this Stackblitz and click the button.

Changes I made to your demo stackblitz:

  1. Updated the mat-progress-buttons to version 9.3.1.
  2. Replaced the demo code with your example code found here.
  3. updated the app.module so it will call the forRoot().
  4. Click the button in the output. This is not spinning.

Desired functionality

The button spinning when setting the active property in code.

Mention any other details that might be useful

This broke in v9.3.1.

#90 might be related

@bartez
Copy link

bartez commented Nov 1, 2021

I have the same issue in my projects. Workaround is downgrade to version 9.1.1.

@CelestialMusa
Copy link

Also on Angular 12, tried downgrading to v9.1.1, spinner is still not showing.

@jorgeluis1706
Copy link

Also on Angular 12, tried downgrading to v9.1.1, spinner is still not showing.

do npm uninstall mat-progress-buttons and later npm install [email protected], that worked for me.

@izzmeifter
Copy link

izzmeifter commented Dec 30, 2021

On Angular 12+

Instead of mutating the object directly like

btnOpts.active = true

try using a spread operator like

btnOpts = { ...this.btnOpts, active: true };

Worked for us. Cheers

@experimint
Copy link

Downgrade to 9.2.1 works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants