Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A smooth way to resize buttons and use different types of mat buttons such as mat-icon-button #68

Open
AbuDawood opened this issue May 21, 2020 · 5 comments
Assignees

Comments

@AbuDawood
Copy link

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ✓] feature request

OS and Version?

Versions

Repro steps

The log given by the failure

Desired functionality

A smooth way to resize buttons and use different types of mat buttons such as mat-icon-button

Mention any other details that might be useful

@michaeldoye michaeldoye self-assigned this May 21, 2020
@michaeldoye
Copy link
Owner

Thanks for request. Could you explain what you mean by "a smooth way to resize the button"?

Icon buttons are available already, see the API here

@AbuDawood
Copy link
Author

AbuDawood commented May 21, 2020

Thank you for your reply.
Based on my check, I think to resize a button I have to set inline to true and use custom class to override current design, right?
I think a button dimension is something too specific than the general and standard design so the dimension should be set explicitly as a property from the option param.
I have tried to use a simple override (spinner case) but I lost the harmony between the button components (spinner kept big, components vertically positioned in the top, so on)

here is a small sample

.prg-btn-sm{
width: 45px !important;
height: 45px !important;
min-height: unset !important;
min-width: unset !important;
}

result is below

image

image

I think I have to do additional work to resize the button without getting deformed, while it should be done without customization intervention

Sorry in advance if the API contains what I am looking for but I didn't notice it

@AbuDawood
Copy link
Author

The second point, I am not sure if I have to open a new issue for it or it is okay to write it here.
Similar to the mat-icon-button type can't be found.

@michaeldoye
Copy link
Owner

ah ok, I see. Thanks for clarifying. I will have a look at what I can do with this for the next release. Thanks!

@AbuDawood
Copy link
Author

Good luck thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants