Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set an exception handler to the worker? #23

Closed
jacobmarcus opened this issue Feb 7, 2013 · 3 comments
Closed

Ability to set an exception handler to the worker? #23

jacobmarcus opened this issue Feb 7, 2013 · 3 comments

Comments

@jacobmarcus
Copy link

Jesque allows to set a custom exception handler to the worker if one chooses to. I don't see a way of doing this in the plugin when the workers are configured externally and started automatically. Would it make sense to expose this as an option?

The reason is that currently the jesque-grails plugin works with the default exception handler. This exception handler does not have any logging and for JedisDataExceptions, the worker is terminated. The main problem with this pattern is that you don't really know if your worker has been terminated.

@michaelcameron
Copy link
Owner

I agree, we've seen some of the same issues. I actually made a grails-jesque 0.5.1 with some logging, but forgot to push it to github. I had to submit a pull request to Jesque (gresrun/jesque#26) to support what I wanted to do. That's there now in Jesque 1.3.0, but there are separate issues (#24) preventing an upgrade for now. I've submitted a pull request and will start working on the changes locally to support setting an exception handler.

@michaelcameron
Copy link
Owner

Could you tell me a little bit more about how you've configure grails-jesque? Are you running your workers entirely by convention (i.e. just job classes with not config), or do you have some of your config in config.groovy? I have some ideas about how to do it, but some options would not work in certain configs.

@michaelcameron
Copy link
Owner

0.8.0 has been published that allows you to set an exception handler on the worker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants