Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed concatenation error #61

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Conversation

truj
Copy link
Contributor

@truj truj commented Jul 21, 2016

I adjust itemsPerPage dynamically via select box. While using the initial value everything was fine. But after changing itemsPerPage, the new perPage value was a string. So the result of end = start + perPage was much too high on any page other than 1.

@michaelbromley michaelbromley merged commit f9e228b into michaelbromley:master Jul 22, 2016
@michaelbromley
Copy link
Owner

Good catch, thanks. I'll write some tests for this case and it'll be in the next release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants