-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination with custom pipe #48
Comments
Hi, |
Just published a new version, 0.3.4. Try it out and let me know if it fixes your issue. |
thanks i think 0.3.4 fixed the issue. However now I found another issue. When im on page 10 then change a filter to limit the items down to 5 pages of results. It will error out showing
|
i had to do enableProdMode( ), not sure if thats a good idea or not thou. |
@tonywong625 Thanks for the report. Enabling prod mode "fixes" things, but not really. In dev mode, Angular runs change detection twice, one to update values, and the second just to ensure that nothing changed after the first pass (which would be bad and breaks the data flow model). That's why you get the exception. In production, checking twice would slow things down, so they only do the first pass and assume you ironed all of the issues out in dev mode. So yeah, this is an issue which I will take a look at. |
@tonywong625 Can you provide a reproduction Plunker of the issue with the change detection? |
I had the same problem ( Instead of
I did:
|
Hey,
Is anyone having issue with custom pipe?
Here is my custom pipe
Component
HTML
When I have showfilter and paginate, no results are shown.
If I change HTML to
Everything is working.
Now if I change HTML to
Pagination works.
Is there a way to have custom pipe working with paginate like the example on your website: http://michaelbromley.github.io/ng2-pagination/ (Full example)
The text was updated successfully, but these errors were encountered: