Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical bars showing from {ifnotingroup id|groupid} {/ifnotingroup} #316

Open
9 of 11 tasks
mwilday opened this issue Dec 31, 2024 · 0 comments
Open
9 of 11 tasks

Comments

@mwilday
Copy link

mwilday commented Dec 31, 2024

Prerequisites

  • I'm reporting the issue to the correct repository.
  • I am running the latest version of this plugin (if not, please upgrade first).
  • I checked the README.md and Wiki documentation but did not find my answer.
  • I searched to make sure that this issue had not already been reported.
  • I have, or I know someone who has, the ability and willingness to test the fix on a Moodle LMS-based site.
  • I am submitting no more than one bug report per issue ticket (please do not submit multiple bugs in one issue ticket).
  • I understand that support is provided by volunteer(s).

What happened?

For some reason, vertical bars are displayed when a block of text is hidden with the ifnotingroup filter tags.{ The bars are also appearing on {ifingroup} tags too,
I think the vertical bar was not coded as a hidden character.

What do you think should have happened?

I expected the lines to be completely hidden.

Steps to reproduce

  1. create a new group in a course and give it the id = pp
  2. create a label on the course home page.
  3. Enter the filter code {ifnotingroup id|pp} NOT IN GROUP {/ifnotingroup}
  4. view the course from a user that is not in the group and see the vertical bars...

Screenshots

This is a screenshot of the vertical bars showing.
image

This is a screenshot of the filtercodes in use.
image

Moodle version

Version 4.3.9 (Build: 20241209)

Installed Moodle UI Language packs.

  • English only
  • One or more other languages/regional dialects (specify below)
  • Other

If other language(s), please specify

n/a

Workaround

no workaround available

Additional information

This is also affecting the ifingroup filter tags that use the same pipe for designating a specific group.

System information

Client Device type: (e.g. Desktop, iPhone or iPad, Android phone or tablet, Other - specify) Macbook Pro
Client Operating System: (e.g. Windows, Linux, Mac OS, Android, iOS, Other - specify) Latest
Client Web Browser: (e.g. Chrome, Edge, Firefox, Safari, Safe Exam Browser, Moodle Mobile App) Chrome, latest build
Server Operating System: (e.g. Windows, Linux, Mac OS, Other - specify) Mac oS

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant