[Flow Manager] CollectionName property should be renamed #167
andredev93
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi!
In the Flow Manager service configuration, with a CRUD persistency management there is a property called collectionName.
It is said (and also implied by the property name) that it contains the name of the CRUD collection to use to persist the data.
The property value is used by Flow Manager to make requests like
POST - {{protocol}}://{{host}}:{{port}}/{{collectionName}}/upsert-one?sagaId={{sagaId}}
.The property must contain the endpoint/path of the CRUD service and not the collection name. Even though they are equal most of the time.
Given that I can configure a CRUD with different collection name and internal endpoint, the Flow Manager requests will not work if I put the collection name in the collectionName property instead of the endpoint.
For example I can configure a CRUD with:
In this case in Flow Manager configuration I should put
"collectionName": "books"
.If I put
"collectionName": "bookscollection"
, the Flow Manager requests will fail.For this reason the collectionName property should be renamed to something that tells me to use the CRUD endpoint and not its name, like
collectionEndpoint
orcollectionPath
for example.Thanks,
Andrea
Beta Was this translation helpful? Give feedback.
All reactions