Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Opt out of extension checks #175

Closed
ns-cweber opened this issue Jul 13, 2019 · 1 comment
Closed

Opt out of extension checks #175

ns-cweber opened this issue Jul 13, 2019 · 1 comment

Comments

@ns-cweber
Copy link

ns-cweber commented Jul 13, 2019

What would you like to have changed?

Remove the errors when the output file path doesn't end in a particular extension (https://github.com/mholt/archiver/blob/master/targz.go#L40). As far as I can tell, these checks are just enforcing a file naming convention; I don't think they help ensure correctness. Seems like the extension checking could be made optional, ideally be decoupling it from the archive action.

Why is this feature a useful, necessary, and/or important addition to this project?

My project builds artifacts and puts them in a file store where the file names are the checksums.

What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?

As a workaround, I'm writing to a tempfile with the required extension (.tar.gz, in my case) and then renaming the file to the checksum.

@mholt
Copy link
Owner

mholt commented Jul 13, 2019

Well, the extension is actually really important. If you need a different file name, just rename it later like you're doing.

History:

@mholt mholt closed this as completed Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants