Support for Unix Shell Flavors and Command Prompt on Windows Simultaneously (Patch Included)

[Alexander-Shukaev]

This bug has been bothering me for several weeks by now. Here is the patch:

--- autoload/sy/util.vim.orig   2013-11-27 10:57:13.622643600 +0100
+++ autoload/sy/util.vim    2013-11-27 10:47:50.253420800 +0100
@@ -6,7 +6,12 @@
 function! sy#util#escape(path) abort
   if exists('+shellslash')
     let old_ssl = &shellslash
-    set noshellslash
+
+    if fnamemodify(&shell, ':t') == 'cmd.exe'
+      set noshellslash
+    else
+      set shellslash
+    endif
   endif

   let path = shellescape(a:path)

So, basically, when one starts Vim from Command Prompt (cmd.exe), then &shell points to cmd.exe indeed, and paths for system() call have to be escaped with noshellslash. However, when one starts Vim from Sh, Bash, Ksh, Csh, etc., then &shell points to one of them, and, in this case, paths for system() call have to be escaped with shellslash, otherwise everything breaks because of backward slashes \ in paths.

I've tested this, and I can assure you that it works fine. Please, incorporate this fix upstream. Thank you.

[mhinz]

Thanks!

Out of interest: what terminal emulators/shells do Windows users usually use? cmd.exe, powershell, cygwin, ..?

And I figure cmd.exe is the only one using backslashes?

[Alexander-Shukaev]

cmd.exe and PowerShell.exe the only ones to use backward slashes. You're probably more interested not in terminal emulators, but in shells. As for shells, yes: cmd.exe, PowerShell.exe, bash.exe, sh.exe, zsh.exe, ksh.exe, csh.exe. Yes, we have ports of all Unix shell flavors available, and they all use forward slashes.

[mhinz]

I see, thanks.