Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-unique jobs can be added even when sidekiq_options unique: :until_executed #251

Closed
USvER opened this issue Nov 3, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@USvER
Copy link

USvER commented Nov 3, 2017

ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

sidekiq (5.0.4)
sidekiq-unique-jobs (5.0.10)

job defined as

class UpsertCollectionWorker
  include Sidekiq::Worker
  sidekiq_options unique: :until_executed

Any ideas?

@mhenrixon
Copy link
Owner

Do you need some configuration for unique arguments maybe?

@mhenrixon mhenrixon self-assigned this Nov 3, 2017
@USvER
Copy link
Author

USvER commented Nov 6, 2017

@mhenrixon i didn't require 'sidekiq-unique-jobs', such an obvious thing to do, but i've read readme numerous times and didn't found this is a requirement. Would be great to update readme.
Thanks.

PS: even when i've added this to my tasks, sidekiq-web still didn't used this gem so deletion of the tasks was not releasing the lock. So one should add require 'sidekiq-unique-jobs' everywhere in the project.

@USvER USvER closed this as completed Nov 6, 2017
@mhenrixon mhenrixon added this to the Version 6.0 milestone Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants