Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'measurement frame' field must be a double matrix, fixes #76 #77

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

ihnorton
Copy link
Contributor

No description provided.

@ihnorton
Copy link
Contributor Author

@tashrifbillah

@addisonElliott
Copy link
Collaborator

PR looks good to me, just need to resolve the tests.

@tashrifbillah
Copy link
Contributor

numpy.set_printoptions() clearly has floatmode argument.
https://docs.scipy.org/doc/numpy-1.14.0/reference/generated/numpy.set_printoptions.html

The only other reason I can think of is the numpy in travis-ci is outdated.

@codecov-io
Copy link

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files           6        6           
  Lines         362      362           
  Branches      117      117           
=======================================
  Hits          319      319           
  Misses         21       21           
  Partials       22       22
Impacted Files Coverage Δ
nrrd/reader.py 83.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b084ed...d32c400. Read the comment docs.

@ihnorton
Copy link
Contributor Author

Updated to fix (realized set_printoptions wasn't doing anything anyway, because any assertion failures go through whatever nose uses to print).

@addisonElliott addisonElliott merged commit c1c42d9 into mhe:master Jan 18, 2019
@tashrifbillah
Copy link
Contributor

@ihnorton , when printing the bvecs, should I use:
np.set_printoptions(suppress= True, floatmode= 'maxprec')
or just set precision= 17 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants