Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaking to read & write tests #124

Merged
merged 6 commits into from
Aug 27, 2022

Conversation

addisonElliott
Copy link
Collaborator

  • Make TestReadingFunctions & TestWritingFunctions subclass of unittest.TestCase for better type suggestions. However, since this test case is meant to be abstract, we nest the class in an Abstract class to prevent test discovery of this class.
  • Add index_order typing for TestReadingFunctions and TestWritingFunctions

@addisonElliott addisonElliott merged commit 4f97d33 into mhe:master Aug 27, 2022
@addisonElliott addisonElliott deleted the fix-tests-pt1 branch August 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant