Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orange Pi should also append company number. #159

Open
mhamidjamil opened this issue Feb 1, 2024 · 3 comments
Open

Orange Pi should also append company number. #159

mhamidjamil opened this issue Feb 1, 2024 · 3 comments
Assignees
Labels
duplicate This issue or pull request already exists new feature Add new feature
Milestone

Comments

@mhamidjamil
Copy link
Owner

No description provided.

@mhamidjamil mhamidjamil self-assigned this Feb 1, 2024
@mhamidjamil mhamidjamil added the new feature Add new feature label Feb 1, 2024
@mhamidjamil
Copy link
Owner Author

As per current functionality we have hard coded company numbers, so the TTGO TCall auto delete these messages after forwarding them to user but we don't need to always update that row by updating code of TTGO TCall so we need to update these numbers using orange pi, what I planned is we should append company messages numbers like we are doing with authentic mobile numbers.

@wasey-rao
Copy link
Collaborator

@mhamidjamil I don't think it's a good approach, although this issue must be resolved as soon as possible as you said you accidentally subscribed other message package, so we need to ignore these company messages but OTP like messages must forwarded, but the approach should be updated, I think we should not just update at the bootup time we should do these changing in the SPIFFS so TTGO can be independent of orange pi in this scenario too. So I'm also creating task in TTGO which will now deal with the strings too after that task you should just write down company messages in a txt file orange pi just read these numbers as TTGO to update its SPIFFS and after confirming this update orange pi update its txt file, hope you under stand, feel free to ping me if you have any query regarding this case.

@wasey-rao wasey-rao transferred this issue from mhamidjamil/orangepi Feb 1, 2024
@wasey-rao wasey-rao added this to the way to V2 milestone Feb 1, 2024
@mhamidjamil
Copy link
Owner Author

I got a better idea, we are not using message of index 1 so, my idea is to save company numbers there and don't delete that message by doing this we can easily fetch company numbers and also can updated from anywhere by sending message with special tag what do you think @wasey-rao?

@mhamidjamil mhamidjamil added the duplicate This issue or pull request already exists label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists new feature Add new feature
Projects
Status: In Progress
Status: No status
Development

No branches or pull requests

2 participants