Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterating through full hypercube #14

Closed
balexbyrd opened this issue Sep 5, 2017 · 2 comments
Closed

Iterating through full hypercube #14

balexbyrd opened this issue Sep 5, 2017 · 2 comments

Comments

@balexbyrd
Copy link

balexbyrd commented Sep 5, 2017

First - I love what you're doing for this community, you've really built some great work.

I was reading through your code and noticed that you're not iterating through the full hypercube. For example, when I run kmeans https://github.com/mhamano/advanced-analytics-toolbox/blob/master/src/lib/js/analysis/kmeans.js R is only going to run the analysis on the first 1500 rows and return a result without an error. This method presents a problem to the end user who assumes it's the full data set which could easily be over 1,500 or even 10K rows - at which point the model needs to handle multiple pages).

While I love the concept of you continuing to build multiple models in short order, this is a very big issue that's not intuitive to a layman end-user and needs to be factored in before this is a fully built, blessed, and distributed solution.

@mhamano
Copy link
Owner

mhamano commented Sep 6, 2017

Hi Alex, thank you for your valuable suggestion. Handling multiple dataPages in scatter charts is one of the functions I left for the future enhancement, and I'll try to include it in the next release.

@mhamano
Copy link
Owner

mhamano commented Sep 11, 2017

@mhamano mhamano closed this as completed Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants