Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to Python 3 #148

Closed
pabs3 opened this issue May 8, 2020 · 5 comments
Closed

port to Python 3 #148

pabs3 opened this issue May 8, 2020 · 5 comments

Comments

@pabs3
Copy link
Contributor

pabs3 commented May 8, 2020

The Python 2 EOL is now passed and distros are starting to remove it. So it is going to become harder to run git-imerge. It would be great to see it ported to Python 3 soon.

https://pythonclock.org/
https://www.enricozini.org/blog/2020/python/python-2-is-dead/

@pabs3
Copy link
Contributor Author

pabs3 commented May 11, 2020

Hmm, the README says it already works with Python 3. So probably the script just needs to use env python3 instead of env python.

@mhagger
Copy link
Owner

mhagger commented Jun 18, 2020

So probably the script just needs to use env python3 instead of env python.

I'm not sure what you mean, concretely. Honestly, I haven't kept up with Python evolution lately, and don't know much about the modern setup system. It used to be you could drop a file in your $PATH and be done with it :-) I'm guessing that somehow setup.py tells what Python version to use, but it seems to allow both Python2 and Python3 already.

If there is somebody who has the time and knowledge to be the "release manager", that would be great, because I don't have either one right now.

@pabs3
Copy link
Contributor Author

pabs3 commented Jun 19, 2020 via email

@mhagger
Copy link
Owner

mhagger commented Jun 20, 2020

Fixed by setuptools changes.

@mhagger mhagger closed this as completed Jun 20, 2020
@waldyrious
Copy link
Contributor

Fixed by setuptools changes.

Ref: #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants