-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script lobSTR_filter_vcf.py failure #78
Comments
Thanks for the comment. When you say fail, do you mean the script crashes, or that the output is not as expected? Lines 175-178 were intended to deal with this case, and add "NOCALL" to the filter field of the entry. If GT is ./., it means we didn't observe any reads at the locus, and thus values for the other fields don't make any sense anyway. Did you expect a different behavior? |
The script crashes with the following traceback: I think the issue is that the on line 157 of the script is not sufficient to ignore cases where GT is ./. . I am using python 2.7.11 with PyVCF (0.6.8). |
I have troubled by the same problem for a whole day! So, could you provide any solution. |
I believe changing line 157, and line 175 of lobSTR_filter_vcf.py to if sample["GT"] and sample["GT"] != "./.": should be sufficient to get rid of this issue. However, I would wait on confirmation from the author. |
The script lobSTR_filter_vcf.py to filter variants fails on cases where the called genotype is "./.", and the subsequent values for "Q", "DISTENDS" are None. For example, the script failed at a location where the sample call was :
Call(sample=xxx, CallData(GT=./., ALLREADS=None, AML=None, DISTENDS=None, DP=None, DPA=None, GB=None, PL=None, PQ=None, Q=None, SB=None, STITCH=None))
A possible solution could be to add a check for ./. in the sample["GT"] values on the two lines that already check to see if sample["GT"] is empty/valid, unless that would have some unintended consequences.
The text was updated successfully, but these errors were encountered: