Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when using semver version #81

Open
DuaelFr opened this issue May 28, 2020 · 4 comments
Open

Do not fail when using semver version #81

DuaelFr opened this issue May 28, 2020 · 4 comments

Comments

@DuaelFr
Copy link

DuaelFr commented May 28, 2020

While trying to get release notes of a module installed by composer, we cannot know if it is using semver version numbers (new good practice) or if it has been converted for an old school drupal.org version number.

For example, I want to get the release notes for the CDN module in its 3.5.0 version given by composer outdated. The drupalorg prn cdn 3.5.0 command throw me a bunch of notices and no content because I should have used drupalorg prn cdn 8.x-3.5 instead.

In the near future, more modules will switch to the semver standard but in the mean time it could help if drupalorg-cli would translate the version for us.

@mglaman
Copy link
Owner

mglaman commented May 28, 2020

Ah yeah. The definitely has not been adjusted for semver, and that's going to be pretty hard, like it was for even implementing it for contrib. Just because it isn't standard and there's no flag on the API to say if a project or release is using it. But a quick regex should help us determine

@hansfn
Copy link
Contributor

hansfn commented May 28, 2020

And the notices should be fixed too. Matt, will you fix (sooN) or should I give it a try and provide a PR?

@mglaman
Copy link
Owner

mglaman commented May 28, 2020

I don't have any free time until maybe this weekend, so it will be a few days before I could try

@DuaelFr
Copy link
Author

DuaelFr commented May 28, 2020

@hansfn if you're working on these notices, you might also want to fix the ones you get when you use a module name that does not exist :)

I came with a quick and dirty fix for the semver issue if it can help you getting started: drupalorg_semver_support-81.patch.txt

Saldy I don't have much time to spend on this for now.
Thanks a lot for your work on this amazing tool and for your reactivity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants