Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default settings do not match recommended settings #800

Closed
walles opened this issue Mar 3, 2023 · 0 comments · Fixed by #799
Closed

Default settings do not match recommended settings #800

walles opened this issue Mar 3, 2023 · 0 comments · Fixed by #799

Comments

@walles
Copy link
Contributor

walles commented Mar 3, 2023 •
edited
Loading

Describe the bug

The default settings...

https://github.com/mgechev/revive/blob/master/defaults.toml

... do not match the recommended settings:

https://github.com/mgechev/revive#recommended-configuration

As a user, I find this confusing.

To Reproduce
Follow the links above and compare the defaults with the recommendations.

Expected behavior
The defaults should match the recommendations.

NOTE
I just fixed actual bugs in my code by enabling unused-parameters warnings, so I totally see why this is recommended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update default rule set to match recommendations walles/revive
1 participant
@walles