Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI bug] mGBA doesn't update savestate screenshots until you move the cursor over other savestates #2929

Merged
merged 9 commits into from
May 23, 2023
Merged

[UI bug] mGBA doesn't update savestate screenshots until you move the cursor over other savestates #2929

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0cf2924
Fix stale save state screenshots via SCREENSHOT_INVALID bits
Utagai May 21, 2023
5e3e71d
Do a shift only once (likely optimized anyways)
Utagai May 21, 2023
5a527c2
Add explanatory comment for future readers
Utagai May 21, 2023
0a27577
Use |= to eliminate need for stateId
Utagai May 21, 2023
8809ac9
Remove SCREENSHOT_STALE in favor of SCREENSHOT_VALID | SCREENSHOT_INV…
Utagai May 21, 2023
6c31d69
Remove extra parentheses
Utagai May 21, 2023
5833a20
Get rid of forgotten variable declaration
Utagai May 21, 2023
c2de342
Improve comment about stale screenshots
Utagai May 23, 2023
23ff11b
Update CHANGES
Utagai May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/feature/gui/gui-runner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,9 @@ void mGUIRun(struct mGUIRunner* runner, const char* path) {
runner->core->reset(runner->core);
break;
case RUNNER_SAVE_STATE:
// If we are saving state, then the screenshot stored for the state previously should no longer be considered up-to-date.
// Therefore, mark it as stale, so that at draw time, we will re-draw to the new save state's screenshot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing is a bit funky. Not super important, but I might change it a bit like so:

Suggested change
// Therefore, mark it as stale, so that at draw time, we will re-draw to the new save state's screenshot.
// Therefore, mark it as stale so that at draw time we load the new save state's screenshot.

((struct mGUIBackground*) stateSaveMenu.background)->screenshotId |= SCREENSHOT_INVALID;
mCoreSaveState(runner->core, item->data.v.u >> 16, SAVESTATE_SCREENSHOT | SAVESTATE_SAVEDATA | SAVESTATE_RTC | SAVESTATE_METADATA);
break;
case RUNNER_LOAD_STATE:
Expand Down