[UI bug] mGBA doesn't update savestate screenshots until you move the cursor over other savestates #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utagai
commented
May 21, 2023
endrift
requested changes
May 21, 2023
endrift
requested changes
May 21, 2023
|
Oops... my bad for the mistakes there! On it. |
endrift
approved these changes
May 23, 2023
There was a problem hiding this comment.
One last thing: since this is a user-reported bug with visible changes, please add an entry to the CHANGES file in the "Other fixes" section, using the mGUI prefix. Changes are sorted alphabetically by section then by when they were added, so if there are other mGUI changes it goes at the bottom of those, but otherwise it goes in alphabetically between the other entries.
src/feature/gui/gui-runner.c
Outdated
| @@ -656,6 +656,9 @@ void mGUIRun(struct mGUIRunner* runner, const char* path) { | |||
| runner->core->reset(runner->core); | |||
| break; | |||
| case RUNNER_SAVE_STATE: | |||
| // If we are saving state, then the screenshot stored for the state previously should no longer be considered up-to-date. | |||
| // Therefore, mark it as stale, so that at draw time, we will re-draw to the new save state's screenshot. | |||
There was a problem hiding this comment.
This phrasing is a bit funky. Not super important, but I might change it a bit like so:
Suggested change
| // Therefore, mark it as stale, so that at draw time, we will re-draw to the new save state's screenshot. | |
| // Therefore, mark it as stale so that at draw time we load the new save state's screenshot. |
|
Thanks! Hopefully I updated the |
endrift
pushed a commit
that referenced
this pull request
Jun 5, 2023
… cursor over other savestates (#2929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2183.
Hi, this is my first PR and @endrift may remember me asking a question or two on the Discord server.
The change itself is quite small but I'll explain it anyways: extend the
SCREENSHOT_*enums in thegui-runner.cfile to include aSCREENSHOT_STALE. This is distinct fromSCREENSHOT_INVALIDbecause we do not want to just draw the current frame onto the background, we want to draw the actual save state screenshot PNG. This is a case that I considered to be equivalent to the!= SCREENSHOT_INVALIDcase in terms of handling, since we basically just want to reload the new PNG image bytes into the background buffer.P.S.
CONTRIBUTING.mdstates that my commit messages should be tagged with their relevant components, but I am not familiar enough with this codebase to be know which components I'm touching. I didn't see any components in the document referring tomGUI.