From 7dcc51379928da6746238e957df3334600e45de4 Mon Sep 17 00:00:00 2001 From: Marcus Gartner Date: Mon, 19 Sep 2022 13:49:04 -0400 Subject: [PATCH] opt: mark FoldInEmpty and FoldNotInEmpty as essential These normalization rules are essential for costfuzz and unoptimized-query-oracle tests until #88141 is fixed. Release note: None --- pkg/sql/opt/xform/optimizer.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/sql/opt/xform/optimizer.go b/pkg/sql/opt/xform/optimizer.go index 29357e93f7ea..9cfcfa8bbe80 100644 --- a/pkg/sql/opt/xform/optimizer.go +++ b/pkg/sql/opt/xform/optimizer.go @@ -1001,6 +1001,9 @@ func (o *Optimizer) disableRulesRandom(probability float64) { // Needed to make sure that dummy columns are pruned so that the // database name is retrieved correctly. int(opt.PruneScanCols), + // TODO(#88141): Needed until a bug in the vectorized engine is fixed. + int(opt.FoldInEmpty), + int(opt.FoldNotInEmpty), ) var disabledRules RuleSet