-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rd party authentication scenario: lighthouse runs for the landing/login page and not the app itself #65
Comments
Hello and first of all, thank you for this very detailed issue 🙏🏻 . I'm going to check this one on my spare time. Concerning the tab that opens, it's "normal", lighthouse opens a new tab when running its audits. Concerning the third party verifications, I'm not sure how to handle this since it's not a scenario I'm very familiar with Cypress. I'm going to try to find time for this. Thank you again 🙏🏻 |
I gave it a repro attempt here with auth0-cypress demo + cypress audit. It is working though. Might need a more complex example. |
Oh great to hear 😊 . Can we consider this issue to be closed or are you expecting something particular in order to be okay with the behavior? And again, a huge thank you for the time spent investigating here 🙏🏻 |
Yup. This is something we will have to retry when Cypress has multi domain support. |
Thank you 🙏🏻 |
@muratkeremozcan can you try with this workaround? |
Fantastic! The workaround helped! Thank you so much for commenting on this closed thread. Words aren't enough to express my appreciation. |
Hi guys,
So my question here is:
Thanks. Feel free to comment. |
What does not work?
We have a landing page -> 3rd party authentication (SiemensID wrapping auth0) -> the app.
We can use both UI login, or prog login. Prog login bypasses landing page and 3rd party authentication page by storing the token in session storage.
Landing page base url is the same as the app.
We login to the app, stabilize the URL. We start lighthouse. Lighthouse launches on a 2nd tab (perhaps expected). All evaluations are done against landing page instead of within the app.
In case we only run against the landing page ( we do not prog-login), the scores are the same. This proves lighthouse always runs against landing whether we are in the app or not.
How to reproduce?
Internal code, not able to share. Would be happy to have a Zoom meeting.
Expected behavior
Lighthouse executes for the application instead of the landing.
Screenshots / Animated Gifs
Video attached using
cypress run --browser chrome
. The video does not show the 2nd tab we see on Test Runner. The 2nd tab shows the landing page.perf.spec.ts.mp4
Environment (please complete the following information):
Any other information that may help fixing the issue?
Add any other context about the problem here.
Whether we prog-login or UI-login, the 2nd tab where the audit is done is not aware of the session context -where the authentication token is stored. This seems like the gist. Changing the base url to the exact app page we want to run does not make a difference; again the 2nd tab is unaware of the session context and evaluates landing page.
This is our simple test.
The text was updated successfully, but these errors were encountered: