-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement seek #44
Implement seek #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first batch of comments. Thanks a lot for making the new PR with the core functionality! It looks very clean.
Co-authored-by: Robin <[email protected]>
Co-authored-by: Robin <[email protected]>
👍 |
The PR looks good. Thanks for taking the time also to implement test cases and working through the review comments. Really happy to finally see seek implemented in FLAC! Cheers,
|
Thanks, it was a lot of fun. I'll catch you two later. Craig PS. You didn't forget about this, did you Robin? PPS. If you wouldn't mind making a release, I'd like to make a PR for beep. |
@cswank singing as we speak! ♩♪♬♩ |
Already done @mewmew! We'll see where it goes: faiface/beep#111 |
Haha that's awesome! Great work @cswank 😁 |
Here we go again!
This one attempts to not break any pre-existing functionality.