Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constraint argument support for strings #2034

Open
cpelley opened this issue Sep 27, 2024 · 0 comments
Open

constraint argument support for strings #2034

cpelley opened this issue Sep 27, 2024 · 0 comments
Labels
good first issue This issue is simpler to address Type:Maintenance

Comments

@cpelley
Copy link
Contributor

cpelley commented Sep 27, 2024

Currently, constraints are expected to be a list of strings. These should be made to support a single string also (i.e. a single string), since this would be the natural UI to expect.

improver should handle 1 of something rather than enforcing an iterable of that something unnecessarily. This sorta change would be in-line with as_cube and as_cubes that I recently added to improver to achieve much the same for standardising cube/cubelist handling.

Example:

constraints: List[str],

@cpelley cpelley added Type:Maintenance good first issue This issue is simpler to address labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is simpler to address Type:Maintenance
Projects
None yet
Development

No branches or pull requests

1 participant