Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional unit tests for regrid to cover subdomains #1737

Open
anja-bom opened this issue Jun 7, 2022 · 1 comment
Open

additional unit tests for regrid to cover subdomains #1737

anja-bom opened this issue Jun 7, 2022 · 1 comment

Comments

@anja-bom
Copy link
Contributor

anja-bom commented Jun 7, 2022

Changes here make sense and look like they will fix the bugs that have been encountered. It would be useful to add tests for this case where the input domain doesn't have full coverage of output domain to avoid similar issues occurring again in the future.

Originally posted by @tjtg in #1720 (review)
@anja-bom anja-bom mentioned this issue Jun 7, 2022
Merged
2 tasks
@fionaRust
Copy link
Contributor

We would also need a unit test to cover passing in integer data into the vicinity processing plugin.

@tjtg tjtg mentioned this issue Jun 8, 2022
Closed
@tjtg tjtg mentioned this issue Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fionaRust @anja-bom