Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages are missing licenses and copyright notice #401

Closed
wkeithchau opened this issue Dec 22, 2023 · 10 comments · Fixed by #402
Closed

Packages are missing licenses and copyright notice #401

wkeithchau opened this issue Dec 22, 2023 · 10 comments · Fixed by #402

Comments

@wkeithchau
Copy link

The licenses and copyright notices are missing from the repo.
Would these packages be using the same copyright notice as the main Meteor repo? Possible to release new versions with licensing.

@radekmie
Copy link
Collaborator

Not a lawyer, but I think that the "license": "MIT" line in package.json should be enough.

@StorytellerCZ
Copy link
Collaborator

I do recall a few years back that for corporate people a dedicated license file is needed. Is that correct @wkeithchau

@wkeithchau
Copy link
Author

Yep, you're spot on @StorytellerCZ .
At least for us, the license file needs to be attached to a published version. If you add a license file now, the current version still isn't valid. A new version needs to be released (I don't believe we can install Meteor packages based off of a GitHub URL/commit?).

@StorytellerCZ
Copy link
Collaborator

You can copy them locally and use them.

@StorytellerCZ StorytellerCZ linked a pull request Jan 2, 2024 that will close this issue
@wkeithchau
Copy link
Author

Can a new version of the package be created as well?
Our legal is quite finicky. The recently added license cannot be applied retrospectively. We would usually reference a git tag (which looks out-of-sync) or a git commit. The git commit for the latest version (2.7.2) does not include the license file that we need.

@StorytellerCZ
Copy link
Collaborator

@Grubba27

@Grubba27
Copy link
Contributor

@wkeithchau
Copy link
Author

That will help make referencing the source code easier.
I was thinking more of a version bump (and new version published) since 2.7.2 was released prior to the license being added.

@StorytellerCZ
Copy link
Collaborator

Also having the LICENSE file at the root of the repository is enough or does it have to also be in the folder from which the package is published as well?

@wkeithchau
Copy link
Author

At the root directory of the repository is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants