Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instant sale action #57

Merged
merged 6 commits into from
Nov 11, 2021
Merged

feat: add instant sale action #57

merged 6 commits into from
Nov 11, 2021

Conversation

kurpav
Copy link
Contributor

@kurpav kurpav commented Nov 9, 2021

No description provided.

zaxozhu
zaxozhu previously approved these changes Nov 9, 2021
@kurpav kurpav changed the title WIP: feat: add instant sale action feat: add instant sale action Nov 10, 2021
b2kdaman
b2kdaman previously approved these changes Nov 10, 2021
@aheckmann
Copy link
Contributor

Please add unit tests

@kurpav
Copy link
Contributor Author

kurpav commented Nov 11, 2021

@aheckmann I'd be glad to write unit tests, but the question is if it makes sense. I propose to add integration tests after we implement auction create flow.

@kurpav kurpav merged commit 7011a90 into main Nov 11, 2021
@kurpav kurpav deleted the feature/instant-sale branch November 11, 2021 08:53
@zaxozhu
Copy link
Contributor

zaxozhu commented Nov 11, 2021

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants