Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offsetOf method on BeetStruct #43

Open
olivbau opened this issue Sep 5, 2022 · 2 comments
Open

offsetOf method on BeetStruct #43

olivbau opened this issue Sep 5, 2022 · 2 comments
Labels
pr pending A pull request to address this issue is pending

Comments

@olivbau
Copy link

olivbau commented Sep 5, 2022

It would be convenient to have an offsetOf method on BeetStruct
Like on myStruct.offsetOf of the buffer-layout package ( https://github.com/pabigot/buffer-layout/blob/main/lib/Layout.js#L1323 )

I'll see if I can do a PR
@olivbau
Copy link
Author

olivbau commented Sep 5, 2022

Here is a PR: #44

@thlorenz thlorenz added the pr pending A pull request to address this issue is pending label Sep 20, 2022
@staccDOTsol
Copy link

That's a great suggestion! The offsetOf method would definitely be a useful addition to the BeetStruct struct. If you're interested in contributing to the project, I would recommend opening an issue on the project's GitHub repository to discuss the idea with the maintainers and get their feedback. Once you have their approval, you can create a pull request with your implementation. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr pending A pull request to address this issue is pending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thlorenz @olivbau @staccDOTsol