Attach release manifests for clusterctl #30
+419
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vknabel
force-pushed
the
attach-release-manifests
branch
from
b752b2b to
a5a2d21
Compare
robertvolkmann
requested changes
Jan 20, 2025
Comment on lines
+36
to
+40
| - env: | ||
| - name: METAL_API_URL | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: controller-manager-config |
There was a problem hiding this comment.
The indentation is inconsistent with the other files!
| @@ -4,5 +4,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: capms-controller | |||
| newTag: latest | |||
| newName: ghcr.io/metal-stack/capms-controller | |||
There was a problem hiding this comment.
Suggested change
| newName: ghcr.io/metal-stack/capms-controller | |
| newName: ghcr.io/metal-stack/cluster-api-metal-stack-controller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the previous release we hand-rolled this process
Closes #23
Closes #29
Here I attach all manifests at the release draft although there will be no tagged image yet. This way we can observe the behavior of the actual release process beforehand.