From 9646bfada2abc8619f39c9ed72d5671e7990b41e Mon Sep 17 00:00:00 2001
From: metagn <metagngn@gmail.com>
Date: Sat, 7 Sep 2024 02:29:05 +0300
Subject: [PATCH] test template default values using other params

fixes #23506
---
 compiler/evaltempl.nim           | 13 +++++++++++++
 compiler/semexprs.nim            |  2 +-
 compiler/semtempl.nim            | 10 ++++++++++
 compiler/semtypes.nim            |  3 +++
 tests/template/tdefaultparam.nim | 15 +++++++++++++++
 5 files changed, 42 insertions(+), 1 deletion(-)
 create mode 100644 tests/template/tdefaultparam.nim

diff --git a/compiler/evaltempl.nim b/compiler/evaltempl.nim
index 5895368bb56b2..c223e11a6f610 100644
--- a/compiler/evaltempl.nim
+++ b/compiler/evaltempl.nim
@@ -33,6 +33,19 @@ proc evalTemplateAux(templ, actual: PNode, c: var TemplCtx, result: PNode) =
     let x = param
     if x.kind == nkArgList:
       for y in items(x): result.add(y)
+    elif nfDefaultRefsParam in x.flags:
+      # value of default param needs to be evaluated
+      # if it contains other template params
+      var res: PNode
+      if isAtom(x):
+        res = newNodeI(nkPar, x.info)
+        evalTemplateAux(x, actual, c, res)
+        if res.len == 1: res = res[0]
+      else:
+        res = copyNode(x)
+        for i in 0..<x.safeLen:
+          evalTemplateAux(x[i], actual, c, res)
+      result.add res
     else:
       result.add copyTree(x)
 
diff --git a/compiler/semexprs.nim b/compiler/semexprs.nim
index 1307b0ab7dfd1..a83da58498636 100644
--- a/compiler/semexprs.nim
+++ b/compiler/semexprs.nim
@@ -813,7 +813,7 @@ proc isUnresolvedSym(s: PSym): bool =
   result = s.kind == skGenericParam
   if not result and s.typ != nil:
     result = tfInferrableStatic in s.typ.flags or
-        (s.kind == skParam and s.typ.isMetaType) or
+        (s.kind == skParam and (s.typ.isMetaType or sfTemplateParam in s.flags)) or
         (s.kind == skType and
         s.typ.flags * {tfGenericTypeParam, tfImplicitTypeParam} != {})
 
diff --git a/compiler/semtempl.nim b/compiler/semtempl.nim
index aef0ce9b370c6..d25977cb2327a 100644
--- a/compiler/semtempl.nim
+++ b/compiler/semtempl.nim
@@ -743,6 +743,16 @@ proc semTemplateDef(c: PContext, n: PNode): PNode =
     c: c,
     owner: s
   )
+  for i in 1..<s.typ.n.len:
+    let param = s.typ.n[i].sym
+    if param.ast != nil:
+      # param default values need to be treated like template body:
+      if sfDirty in s.flags:
+        param.ast = semTemplBodyDirty(ctx, param.ast)
+      else:
+        param.ast = semTemplBody(ctx, param.ast)
+      if param.ast.referencesAnotherParam(s):
+        param.ast.flags.incl nfDefaultRefsParam
   if sfDirty in s.flags:
     n[bodyPos] = semTemplBodyDirty(ctx, n[bodyPos])
   else:
diff --git a/compiler/semtypes.nim b/compiler/semtypes.nim
index 5faefc9aab920..6a6ffa2d4010d 100644
--- a/compiler/semtypes.nim
+++ b/compiler/semtypes.nim
@@ -1365,6 +1365,9 @@ proc semProcTypeNode(c: PContext, n, genericParams: PNode,
           "either use ';' (semicolon) or explicitly write each default value")
         message(c.config, a.info, warnImplicitDefaultValue, msg)
       block determineType:
+        if kind == skTemplate and hasUnresolvedArgs(c, def):
+          def.typ = makeTypeFromExpr(c, def.copyTree)
+          break determineType
         let isGeneric = isCurrentlyGeneric()
         inc c.inGenericContext, ord(isGeneric)
         def = semExprWithType(c, def, {efDetermineType, efAllowSymChoice}, typ)
diff --git a/tests/template/tdefaultparam.nim b/tests/template/tdefaultparam.nim
new file mode 100644
index 0000000000000..ecbb0e1453d3d
--- /dev/null
+++ b/tests/template/tdefaultparam.nim
@@ -0,0 +1,15 @@
+block:
+  template foo(a: untyped, b: untyped = a(0)): untyped =
+    let x = a(0)
+    let y = b
+    (x, y)
+  proc bar(x: int): int = x + 1
+  doAssert foo(bar, b = bar(0)) == (1, 1)
+  doAssert foo(bar) == (1, 1)
+
+block: # issue #23506
+  var a: string
+  template foo(x: int; y = x) =
+    a = $($x, $y)
+  foo(1)
+  doAssert a == "(\"1\", \"1\")"