Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested paths in retain() Fix function. #329

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Add support for nested paths in retain() Fix function. #329

merged 2 commits into from
Nov 20, 2023

Conversation

blackwinter
Copy link
Member

Resolves #145.

@blackwinter blackwinter requested a review from fsteeg October 31, 2023 12:39
@blackwinter blackwinter mentioned this pull request Oct 31, 2023
Closed
@TobiasNx
Copy link
Collaborator

TobiasNx commented Nov 8, 2023

Looks good, tested a buch of variations. It seems that $last and $first are not supported yet.

@blackwinter
Copy link
Member Author

Thanks. Implemented in 5cc686d.

@blackwinter
Copy link
Member Author

@fsteeg: There's quite some overlap with FixPath here that I wasn't able to capitalize on. We should at least keep that in mind and try to refactor at some point.

@TobiasNx
Copy link
Collaborator

TobiasNx commented Nov 9, 2023

Looks good, tested a buch of variations. It seems that $last and $first are not supported yet.

The adjustments seem to work +1

@TobiasNx
Copy link
Collaborator

@fsteeg did you see this review-request?

@fsteeg
Copy link
Member

fsteeg commented Nov 20, 2023

@fsteeg did you see this review-request?

Sorry, seems I missed it, thanks for the reminder.

@fsteeg fsteeg assigned blackwinter and unassigned fsteeg Nov 20, 2023
@blackwinter blackwinter merged commit 49e3fb1 into master Nov 20, 2023
1 check passed
@blackwinter blackwinter deleted the 145-retainNested branch November 20, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsteeg fsteeg fsteeg approved these changes

Assignees

@blackwinter blackwinter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retain does not work, if you only want to keep certain subfields
3 participants
@blackwinter @TobiasNx @fsteeg