Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snippets for do binds in extension #302

Closed
katauber opened this issue May 15, 2023 · 7 comments · Fixed by #336
Closed

Add snippets for do binds in extension #302

katauber opened this issue May 15, 2023 · 7 comments · Fixed by #336
Assignees

Comments

@katauber
Copy link
Member

katauber commented May 15, 2023

See do binds https://github.com/metafacture/metafacture-fix#binds

functional review: @TobiasNx
code review: @fsteeg

@katauber katauber converted this from a draft issue May 15, 2023
@katauber katauber moved this from Ready to Selected in Metafacture May 15, 2023
@katauber katauber self-assigned this May 15, 2023
@katauber katauber moved this from Selected to Ready in Metafacture Aug 7, 2023
@katauber
Copy link
Member Author

katauber commented Nov 9, 2023

I am not sure anymore what to do here. There is a snippet with suggests the "do-bind" with collector, args and body.

Image

What do we need here @TobiasNx?

@katauber katauber moved this from Ready to Backlog in Metafacture Nov 9, 2023
@TobiasNx
Copy link
Collaborator

TobiasNx commented Nov 9, 2023

To be honest I am not sure.
Collector is wrong should be at least bind.
I think there should be snippets for the specific binds.
Perhaps we should talk about it in the next planning meeting, or @fsteeg knows what we intended here.

@fsteeg
Copy link
Member

fsteeg commented Nov 9, 2023

As far a as I remember this was about updating the terminology, collectors are a Morph concept, should be bind like Tobias said, and in the parentheses it can get parameters (simple values) and/or options (key-value-pairs).

@katauber
Copy link
Member Author

katauber commented Nov 9, 2023

So maybe we want something like this, when yo start typing "do":

Image

And if you choose one entry, it looks like this:

Image

Do we need a specific dexcription for each do bind? The current description is "A do bind changes the execution context of the body functions. They are executed for each element in the list." I think that matches for every do bind :)
And at the moment I'm not sure, where the description is displayed 🙃

@katauber
Copy link
Member Author

katauber commented Nov 9, 2023

parameters or options like this?

Image

Do we want bind or one snippet for every possible bind @TobiasNx @fsteeg ?

@katauber
Copy link
Member Author

katauber commented Nov 9, 2023

Discussed offline with @fsteeg to implement a snippet for each do bind.

@katauber katauber moved this from Backlog to Selected in Metafacture Nov 9, 2023
@katauber katauber moved this from Selected to Working in Metafacture Nov 9, 2023
@katauber katauber moved this from Working to Review in Metafacture Nov 10, 2023
@katauber katauber assigned TobiasNx and unassigned katauber Nov 10, 2023
@katauber katauber assigned fsteeg and unassigned TobiasNx Dec 11, 2023
@fsteeg
Copy link
Member

fsteeg commented Dec 11, 2023

Nice, very useful with the inline documentation and templates for the different do binds! +1

@fsteeg fsteeg assigned katauber and unassigned fsteeg Dec 11, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants