Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO-URL returns incorrect value for % symbol #2009

Closed
rebolbot opened this issue Apr 2, 2013 · 6 comments
Closed

TO-URL returns incorrect value for % symbol #2009

rebolbot opened this issue Apr 2, 2013 · 6 comments
Labels

Comments

@rebolbot
Copy link
Collaborator

rebolbot commented Apr 2, 2013

Submitted by: johnk

TO-URL does not encode % correctly when passed in a string or char

Reference to discussion on google groups:

https://groups.google.com/d/msg/rebol/rquLOryb5nM/Srahpr_71-0J
In R2
>> to-url #"%"
== %
In R3
>> to-url #"%"
== %25

CC - Data [ Version: r3 master Type: Bug Platform: All Category: Native Reproduce: Always Fixed-in:none ]

@rebolbot
Copy link
Collaborator Author

rebolbot commented Apr 2, 2013

Submitted by: Ladislav

This may as well be just a MOLD bug, I do not think the TO-URL behaviour is incorrect.

@rebolbot
Copy link
Collaborator Author

rebolbot commented Apr 2, 2013

Submitted by: johnk

Reading this I agree that this should not be a bug.

https://en.wikipedia.org/wiki/Percent-encoding

Equivalent code in ruby

>> URI::encode "%"
=> "%"

@rebolbot
Copy link
Collaborator Author

rebolbot commented Apr 2, 2013

Submitted by: BrianH

TO-URL, like all of the TO-datatype functions, only does datatype conversion. It doesn't and is not supposed to do any encoding. R3 has encoding bugs (there are many tickets about this) but it's not TO-URL's fault.

@rebolbot
Copy link
Collaborator Author

rebolbot commented Apr 3, 2013

Submitted by: johnk

Thanks for the clarification Brian

@rebolbot
Copy link
Collaborator Author

rebolbot commented Apr 3, 2013

Submitted by: Ladislav

See #2010, #2011 and #2012.

@rebolbot
Copy link
Collaborator Author

rebolbot commented Apr 4, 2013

Submitted by: BrianH

See #482, #1327, #1333 and #1644 for the existing tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant