Merge pull request #4 from metacall/rendering-at-req #4
Annotations
9 warnings
useless use of `format!`:
metassr-cli/src/cli.rs#L79
warning: useless use of `format!`
--> metassr-cli/src/cli.rs:79:22
|
79 | f.write_str(&format!(
| ______________________^
80 | | "{}",
81 | | match *self {
82 | | Self::SSG => "ssg",
83 | | Self::SSR => "ssr",
84 | | }
85 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
help: consider using `.to_string()`
|
79 ~ f.write_str(&(match *self {
80 + Self::SSG => "ssg",
81 + Self::SSR => "ssr",
82 ~ }).to_string())
|
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
metassr-cli/src/cli.rs#L68
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> metassr-cli/src/cli.rs:68:1
|
68 | impl Into<server::BuildingType> for BuildingType {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<cli::BuildingType>`
|
68 ~ impl From<BuildingType> for server::BuildingType {
69 ~ fn from(val: BuildingType) -> Self {
70 ~ match val {
71 ~ BuildingType::SSG => server::BuildingType::StaticSiteGeneration,
72 ~ BuildingType::SSR => server::BuildingType::ServerSideRendering,
|
|
name `SSR` contains a capitalized acronym:
metassr-cli/src/cli.rs#L65
warning: name `SSR` contains a capitalized acronym
--> metassr-cli/src/cli.rs:65:5
|
65 | SSR,
| ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
|
name `SSG` contains a capitalized acronym:
metassr-cli/src/cli.rs#L63
warning: name `SSG` contains a capitalized acronym
--> metassr-cli/src/cli.rs:63:5
|
63 | SSG,
| ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssg`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
|
you should consider adding a `Default` implementation for `Rand`:
crates/metassr-utils/src/rand.rs#L11
warning: you should consider adding a `Default` implementation for `Rand`
--> crates/metassr-utils/src/rand.rs:11:5
|
11 | / pub fn new() -> Self {
12 | | let val = RandomState::new().build_hasher().finish() as i64;
13 | | Self(val.abs())
14 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
10 + impl Default for Rand {
11 + fn default() -> Self {
12 + Self::new()
13 + }
14 + }
|
|
methods called `new` usually return `Self`:
crates/html-generator/src/html_props.rs#L17
warning: methods called `new` usually return `Self`
--> crates/html-generator/src/html_props.rs:17:5
|
17 | / pub fn new() -> HtmlPropsBuilder {
18 | | HtmlPropsBuilder::new()
19 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
= note: `#[warn(clippy::new_ret_no_self)]` on by default
|
direct implementation of `ToString`:
crates/html-generator/src/builder.rs#L26
warning: direct implementation of `ToString`
--> crates/html-generator/src/builder.rs:26:1
|
26 | / impl ToString for HtmlOutput {
27 | | fn to_string(&self) -> String {
28 | | self.0.clone()
29 | | }
30 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|