Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition 2021 not supported #46

Open
ghost opened this issue Feb 3, 2022 · 6 comments
Open

Edition 2021 not supported #46

ghost opened this issue Feb 3, 2022 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 3, 2022

cargo-bitbake doesn't support edition 2021 in Cargo.toml

$ cargo bitbake
error: failed to parse manifest at `/home/snke/git/xxx/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  this version of Cargo is older than the `2021` edition, and only supports `2015` and `2018` editions.
$ cargo bitbake --version
cargo-bitbake 0.3.15
@ghost
Copy link

ghost commented Feb 4, 2022

I'm running into the same problem.. Is there a workaround?

@acz2022
Copy link

acz2022 commented Mar 29, 2022

Yeah, me too. This actually is a show stopper for my rust project

@GiorgioBertolotti
Copy link

@cardoe Could you please take a look at this?

@GiorgioBertolotti
Copy link

@SnkE @Pan5ky @acz2022 as a workaround you can install the version with updated dependencies from PR #45.
To do so you can run cargo install --locked --git https://github.com/otavio/cargo-bitbake.
Please note that if you've previously installed the original version you should run cargo uninstall cargo-bitbake to remove it.

@cletustboone
Copy link

@GiorgioBertolotti worked for me. Hoping this can get merged and published soon.

@acz2022
Copy link

acz2022 commented Apr 20, 2022

@GiorgioBertolotti Thanks for the reply. There is unfortunately more to that. At the moment cargo-bitbake is not able to produce correct recipe (it creates almost correct) for rust app that uses gtk3. What needed to be added to my recipe after generating it via cargo bitbake:

  1. inherit pkgconfig
  2. DEPENDS = "glibc cairo gtk+3 gdk-pixbuf atk pango"

But I still think it is a great work and I'm sure it will only get better.
Cheers

Bravo555 added a commit to Bravo555/cargo-bitbake that referenced this issue Feb 2, 2023
The dependencies were upgraded to handle [workspace inheritance
introduced in cargo 1.64][1]. MSRV was set to the minimal version
required to compile (1.65 due to usage of let else in cargo).

This PR resolves meta-rust#60. On the same note meta-rust#46 should also probably get
closed since AFAIK it's already been resolved.

[1]: rust-lang/cargo#10859

Signed-off-by: Marcel Guzik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants